-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webui App #30
Add webui App #30
Conversation
Making change suggestions as I go:
|
@j-dominguez9
|
@snekkenull Thank you for your work on this and incorporating the changes. I went ahead and made minor formatting fixes to conform with python style. The only thing it's missing before merging and hoping you could help with this last detail is an error that comes out when you press the Clear button. Attached output below. Thanks! |
@j-dominguez9 Thank you for testing, I have benefited greatly from your code style and work. |
…t start, but traces back to ta source
@snekkenull of course! Thank you for your contribution. Note for self future reference: There is still an error if the user doesn't have an OPENAI_API_KEY in the .env file, even if they don't intend to use OpenAI. This however traces back to the utils file, which will be addressed soon, so I'll come back to this part afterwards to make sure it works without having an OpenAI key. |
@snekkenull many thanks for working on the app! One small issue I just noticed are several inconsistencies between the READMEs. Would you be able to take a stab at those?
|
Thank you very much for your suggestions and feedback.
It is true that some of the documentation is an expression of past versions
that were not revised in a timely manner.
The current version uses OpenAI-compatible format APIs with less
dependencies and pervasiveness, but is not easily extensible.
In response to your feedback, I will make a submission in the next update.
Thanks again for the reminder. 🙇
Nedelina Teneva ***@***.***> 于2024年7月12日周五 08:18写道:
… @snekkenull <https://github.com/snekkenull> many thanks for working on
the app! One small issue I just noticed are several inconsistencies between
the READMEs. Would you be able to take a stab at those?
- Can you double check for consistency with the main README and edit
as needed? For example, the app README says "This repository contains..."
and has its own contributing guide - those can be removed/adjusted as this
is now part of this repo.
- Explicitly list all the APIs supported.
- Also briefly describe the advanced options the UI supports.
- I think the Linux and Window installation can be added to the main
README. You can briefly describe what the '--with app' option is and link
to the app directory.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5UFKQWJ4LVCTXT5JDG7SALZL4OG5AVCNFSM6AAAAABKDJFJG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRUGE3DSNBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
#23
Changelog
Add a gradio WebUI for translation-agent, run it locally or cloud.
...Any OpenAI compatible LLMs, just set the base url in UI.
Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)
pre-commit install
)pytest tests